Fix resource manager permissions save issues

[Adeoluwa-Simeon]

Fixes #6045

Summary

Fix resource manager permissions save issues

• set default PortalID in vw_FolderPermissions to -1
• include other selected permissions when 'Write to Folder' permisison is set
• update javascript to fix allowAccess==0 permissions issues

Release notes

Resolved an issue where the permissions in the resource manager were not being saved and fixed some of the auto adjust enable and disable permission functions.

Testing steps

Re-run the steps in #6045 and check that the issues are solved

[Adeoluwa-Simeon]

@microsoft-github-policy-service agree company="Trilogy"

[mitchelsellers]

@Adeoluwa-Simeon Thank you for this submission. Overall I think that this change resolves the reported issue, however, I am slightly concerned with the impact of changing the behavior of a Null Portal id on a view that is used in other locations. Upon a quick search that view is utilized by a number of other areas of the platform and I'm concerned that there would be unintended consequences with this change that are going to be hard, if not impossible to fully track.

@dnnsoftware/approvers thoughts?

[david-poindexter]

@Adeoluwa-Simeon Thank you for this submission. Overall I think that this change resolves the reported issue, however, I am slightly concerned with the impact of changing the behavior of a Null Portal id on a view that is used in other locations. Upon a quick search that view is utilized by a number of other areas of the platform and I'm concerned that there would be unintended consequences with this change that are going to be hard, if not impossible to fully track.

@dnnsoftware/approvers thoughts?

@mitchelsellers I tend to lean to your thought process here as well. I'd be interested to hear what @valadas thinks about this.

[Adeoluwa-Simeon]

An alternative solution would be to modify the procedure that calls the view
from

CREATE PROCEDURE [dbo].[GetFolderPermissionsByPortalAndPath]
@portalid int,
@FolderPath nvarchar(300)
AS
BEGIN
SET @portalid = IsNull(@portalid, -1)

SELECT *
FROM dbo.[vw_FolderPermissions]
WHERE PortalID = @portalid AND (FolderPath = @FolderPath OR @FolderPath IS NULL)
END

to cater to both portalId being null and -1, essentially solving the need for a default value

CREATE PROCEDURE [dbo].[GetFolderPermissionsByPortalAndPath]
@portalid int,
@FolderPath nvarchar(300)
AS
BEGIN

SELECT *
FROM dbo.[vw_FolderPermissions]
WHERE (PortalID = IsNull(@portalid, -1) OR (@portalid IS NULL AND PortalID IS NULL)) AND (FolderPath = @FolderPath OR @FolderPath IS NULL)
END

[mitchelsellers]

I believe that this is an acceptable change, but I will need to review this to validate

[leonhardholz]

@valadas @mitchelsellers Is it possible to get this fix into the next release? We have customers complaining about the problem.

[mitchelsellers]

This will need to be 09.13.04 at minimum since 9.13.03 has been released

[mitchelsellers]

@valadas @david-poindexter Any thoughts on this? I have not had a chance to test/validate the actual change

[valadas]

I downloaded this build and it does fix everything mentioned in the original issue.

Just need to rename that sql file for next version (09.13.04)
In a perfect world if while you are in this area if you could take a look at #5857 steps, it would be awesome if it could be fixed in the PR too as it is probably something similar for a fix.

[Adeoluwa-Simeon]

@valadas I have updated the file name.
I took a quick look at the #5857 issue, it would take some time for me to do a fix, it seems to be more than the null reference.

[valadas]

Looks good to me

[leonhardholz]

Great, thank you. Can this be merged now?

[valadas]

Just needs a second approver

[mitchelsellers]

@valadas looks like we have a merge conflict? I'm on vacation but will try to review soon

[valadas]

Conflict resolved

[leonhardholz]

Thanks everyone! Is there an ETA for the 9.13.4 release?

[valadas]

It's not a promise but I think it may happen early next week.

[leonhardholz]

@valadas How's the release coming along?

[valadas]

With the US holidays it won't be this week, we are meeting next week and will analyze the situation then