-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Sorting (A-Z) members of roles in PersonaBar #6018
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -246,11 +246,11 @@ public HttpResponseMessage GetRoleUsers(string keyword, int roleId, int pageInde | |||
Localization.GetString("InvalidRequest", Components.Constants.LocalResourcesFile)); | |||
} | |||
|
|||
var users = RoleController.Instance.GetUserRoles(this.PortalId, Null.NullString, role.RoleName); | |||
var users = RoleController.Instance.GetUserRoles(this.PortalId, Null.NullString, role.RoleName).OrderBy(x => x.FullName).ToList(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move the OrderBy
call to the beginning of line 260? This would allows us to only specify it once, and avoid creating another copy of the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes of course, I fix it.
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/RolesController.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Fix #5994: Sorting (A-Z) members of roles in PersonaBar