Fixed persistance of "Replace Tokens" setting in module cache #5846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valadas
approved these changes
Oct 14, 2023
|
I've pushed a commit which clears all of the caches associated with the portal when the settings change. Look right? |
GerardSmit
commented
Oct 16, 2023
DNN Platform/Library/Entities/Modules/Settings/SettingsRepository.cs
Outdated
Show resolved
Hide resolved
|
Looks good 👍, thanks for the addition. |
mitchelsellers
approved these changes
Oct 16, 2023
valadas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5844
Summary
Currently the module cache is being retrieved from the portal cache because we're only using the portal ID as key. Now we're using both the portal and module ID to generate a key.
If there is no module, then we use -1 as module ID; which is the null-value.