Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop on install #5788

Merged

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Aug 8, 2023

Fixes #5785

@bdukes bdukes added this to the 9.12.1 milestone Aug 8, 2023
@bdukes bdukes requested a review from valadas August 8, 2023 20:34
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks promising, will download that build and try it out :) Thanks!

@valadas
Copy link
Contributor

valadas commented Aug 9, 2023

Worked for me, getting another issue but this fixes that part. Thanks @bdukes

Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🎉

@david-poindexter david-poindexter merged commit 827790d into dnnsoftware:develop Aug 9, 2023
3 checks passed
@david-poindexter david-poindexter deleted the fix/di-scope-infinite-loop branch August 9, 2023 01:04
@valadas valadas modified the milestones: 9.12.1, 9.13.0 Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Can't install current develop branch artifact (clean install)
3 participants