-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped webpack to v5 #5570
Bumped webpack to v5 #5570
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I don't get it, the build error has nothing to do with these changes... @bdukes do you have any clue about the binlog version (assuming that is the problem here)... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valadas this looks great! One question. I see the webpack
script (which uses webpack-dev-server ...
) has been removed from all the package.json files. What is replacing this? Are we recommending just using the webpack CLI now for this? If so, do the Cake scripts need to be up updated accordingly? (I honestly can't remember if those used this or not in the scoped build options.)
It was because since we have |
That makes perfect sense - thanks for the explanation. And seriously...thank you for this PR! |
Bumped webpack to v5
This removes the workarounds put in place in 9.11.1 so the build works in CI where node was upgrade to v18. Our build should now work on node 16 and 18 without workaround in place... Hopefully.
I tested a full build and confirmed all the modules still load up fine.