Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically handle TLS negotiation for MailKit #4479

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Automatically handle TLS negotiation for MailKit #4479

merged 1 commit into from
Feb 10, 2021

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Feb 10, 2021

@bdukes bdukes added this to the 9.9.0 milestone Feb 10, 2021
@bdukes bdukes changed the base branch from develop to release/9.9.0 February 10, 2021 13:58
david-poindexter
david-poindexter approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks @bdukes 🎉

@david-poindexter
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

valadas
valadas approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@valadas
Copy link
Contributor

valadas commented Feb 10, 2021

Oops, there is this error though
D:\a\1\s\DNN Platform\Library\Services\Mail\MailKitMailProvider.cs(158,52): error CS0103: The name 'SecureSocketOptions' does not exist in the current context [D:\a\1\s\DNN Platform\Library\DotNetNuke.Library.csproj]

@bdukes
Copy link
Contributor Author

bdukes commented Feb 10, 2021

I've pushed a change with the missing using statement, sorry about that.

@valadas valadas merged commit 739cf92 into dnnsoftware:release/9.9.0 Feb 10, 2021
@bdukes bdukes deleted the starttls branch February 12, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-poindexter david-poindexter david-poindexter approved these changes

@valadas valadas valadas approved these changes

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
9.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bdukes @david-poindexter @valadas