Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecates dependencies in common bundle #4467

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

valadas
Copy link
Contributor

@valadas valadas commented Feb 8, 2021

The common bundle goal was to put on the page stuff that most of our React modules use in order to reduce each of the bundles for individual modules at the cost of a larger common bundle. This is nice but several of the exported (Webpack Externals) packages are simply not used by any module or a single module.

This PR marks all of those deprecated for removal in v.10 except es6-promise which is a polyfill needed to support IE11 and it's used by some of the modules.

It also removes all development time only dependencies, which should not even be distributed. I was hoping for a big file reduction, but well, it will remove about 300Kb to the bundle when we do remove it, so it's better than nothing 🤷

The common bundle goal was to put on the page stuff that most of our React modules use in order to reduce each of the bundles for individual modules at the cost of a larger common bundle. This is nice but several of the exported (Webpack Externals) packages are simply not used by any module or a single module.

This PR marks all of those derprecated for removal in v.10 except es6-primise which is a polyfill needed to support IE11 and it's used by some of the modules.
@valadas valadas changed the title Derprecate dependencies in common bundle Deprecates dependencies in common bundle Feb 8, 2021
@valadas valadas added this to the 9.9.0 milestone Feb 8, 2021
@donker donker merged commit 9730827 into dnnsoftware:develop Feb 8, 2021
@valadas valadas deleted the deprecate-bundle-dependencies branch April 14, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants