-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Logging to the Dependency Injection SafeGetTypes function #4455
Add Logging to the Dependency Injection SafeGetTypes function #4455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left 2 comments just to get other eyes on these concerns...
DNN Platform/DotNetNuke.DependencyInjection/Extensions/TypeExtensions.cs
Outdated
Show resolved
Hide resolved
DNN Platform/DotNetNuke.DependencyInjection/Extensions/TypeExtensions.cs
Outdated
Show resolved
Hide resolved
This clearly marks the new dependency in our nuget packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so I added the dependency in our nuspec file and I am ok with these changes until we have something different for logging.
DNN Platform/DotNetNuke.DependencyInjection/Extensions/TypeExtensions.cs
Show resolved
Hide resolved
DNN Platform/DotNetNuke.DependencyInjection/Extensions/TypeExtensions.cs
Outdated
Show resolved
Hide resolved
👍 Ready to merge (let's do a Squash Merge on this one) once the build is complete. |
Fixes #4454
Summary
Added logging to the SafeGetTypes function. The function would successfully load the types safely, without crashing, but would eat any exceptions that were thrown about missing references. I have added an
ILog
parameter to the function to print out the missing types.