Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecation for some DataProvider methods #4259

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Remove deprecation for some DataProvider methods #4259

merged 1 commit into from
Nov 11, 2020

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Oct 28, 2020

Fixes #3830

@bdukes bdukes added this to the 9.8.1 milestone Oct 28, 2020
valadas
valadas approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sleupold sleupold mentioned this pull request Nov 11, 2020
Closed
valadas
valadas approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@valadas valadas merged commit 06f747b into dnnsoftware:develop Nov 11, 2020
@bdukes bdukes deleted the remove-dataprovider-deprecations branch November 30, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchelsellers mitchelsellers mitchelsellers approved these changes

@valadas valadas valadas approved these changes

Assignees
No one assigned
Labels
Type: Maintenance
Projects
None yet
Milestone
9.8.1
Development

Successfully merging this pull request may close these issues.

Deprecation for ExecuteDataSet
3 participants
@bdukes @mitchelsellers @valadas