Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap CodeMirror in ConfigConsole for monaco-editor #4173

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

david-poindexter
Copy link
Contributor

Summary

Resolves #4169

Please see the linked issue for more details on why this was implemented without package management. It is a stepping-stone PR to get the editor integrated into a project that does not already have package management set up.

image

image

image

image

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mitchelsellers mitchelsellers merged commit 83af9dd into dnnsoftware:develop Oct 12, 2020
@david-poindexter david-poindexter deleted the issue-4169 branch May 31, 2021 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swap CodeMirror in ConfigConsole for monaco-editor
3 participants