Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message to use correct error icon #4124

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

tauqeer-haider
Copy link
Contributor

Fixes #4123

Summary

The error path was using notify method to show error instead of notifyError method which results in showing incorrect notification icon. Fixed it to use correct method.

Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdukes bdukes added this to the Future: Patch milestone Sep 24, 2020
@mitchelsellers mitchelsellers modified the milestones: Future: Patch, 9.7.3 Sep 24, 2020
@mitchelsellers mitchelsellers merged commit 1c82b05 into dnnsoftware:develop Sep 24, 2020
@valadas valadas modified the milestones: 9.7.3, 9.8.0 Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect error icon (green check mark) shown on pages panel when unexpected error occurred
4 participants