Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat warnings as errors for DotNetNuke.Instrumentation #4122

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Treat warnings as errors for DotNetNuke.Instrumentation #4122

merged 1 commit into from
Sep 25, 2020

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Sep 23, 2020

  • Adds missing documentation
  • Removes internal fields (changing to private or properties as appropriate)
  • Remove underscores from field names

@bdukes bdukes added this to the Future: Patch milestone Sep 23, 2020
valadas
valadas approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mitchelsellers mitchelsellers merged commit 6f883ba into dnnsoftware:develop Sep 25, 2020
@bdukes bdukes deleted the instrumentation-warnings branch September 25, 2020 13:41
@bdukes bdukes modified the milestones: Future: Patch, 9.7.3 Sep 28, 2020
@valadas valadas modified the milestones: 9.7.3, 9.8.0 Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchelsellers mitchelsellers mitchelsellers approved these changes

@valadas valadas valadas approved these changes

Assignees
No one assigned
Labels
Type: Maintenance
Projects
None yet
Milestone
9.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bdukes @mitchelsellers @valadas