Cleanup Upgrade/Installer Code #4119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and accounted "Check"
…nts prior to installation now
…items to be removed
bdukes
approved these changes
Sep 22, 2020
valadas
requested changes
Sep 23, 2020
|
/azp run |
|
No pipelines are associated with this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4118
This PR removes all unused code that is used to complete upgrades prior to 7.4.2 and earlier.
Background
A bit of important background, in addition to what was initially noted in the Issue.
DNN Platform, upon install starts by applying an initial script, then it "Upgrades" the application from one version to another until it is fully updated. Currently, the DotNetNuke.Install.Config file starts this process at 08.00.04 and upgrades from there. For extra safety I only removed upgrade steps to 7.4.2.
As a reminder, if you follow the upgrade path, the removal of these elements will have NO impact as the upgrade to 7.4.2 alone would have processed these items. Given this, I do NOT believe that this a breaking change.
Included Cleanups
Included in this cleanup is removal of the following items: