Removal of references to the Dashboard Project Type #4117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdukes
reviewed
Sep 22, 2020
| internal const string DefaultProviderImage = "icon_provider.gif"; | ||
| internal const string DefaultLibraryImage = "icon_library.png"; | ||
| internal const string DefaultWidgetImage = "icon_widget.png"; | ||
| internal const string DefaultDashboardImage = "icon_dashboard.png"; |
There was a problem hiding this comment.
Do we want to delete this image also? Or leave it since someone might be using it for something else?
There was a problem hiding this comment.
I think we have to leave the image due to others possibly using it
bdukes
reviewed
Sep 22, 2020
bdukes
approved these changes
Sep 22, 2020
donker
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4114
Upon further review, since version 8.0.0 it has been impossible to install, or uninstall Dashboard components. However, there were lingering references. Given this, I have opted in this PR to remove the references rather than simply flagging as there wasn't anything easily flaggable. I can adjust if needed.