Search Results UI Alignment changes #4074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
THanks for the submission! Do you happen to have any before/after comparison images? Paging @valadas and @david-poindexter for review |
|
Hi @mitchelsellers, Yes, sure. Have attached them below. Thank you for the speedy response! Before
After
|
|
Thanks! This helps us validate your intended before & after. I'll defer to others for the proper nature of these. |
david-poindexter
approved these changes
Sep 9, 2020
There was a problem hiding this comment.
Thank you @kieran23101 for the contribution. This is a great improvement and I'll target this for a Future: Minor release due to the possibility of it being a potential breaking change for some themes that may be styling Search Results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These are very minimal changes to make the SearchResults page look more appealing, these are things that I seem to be repeating when creating a DNN installation and I'm sure that many other do too.
This PR is is a suggestion and there is no issues with it not being done, just thought I'd try and be helpful...
Please let me know if this will have a negative impact on the system.
Regards
Kieran