Use request scope in PortalModuleBase #4053
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4046
Summary
Currently every PortalModule create its own service scope. This PR changes this behaviour by using the request scope when possible.
If a PortalModule is created outside ASP.Net (or the HttpContext was not available) it'll still create a new scope.
I've placed the unit test in the same directory as
DnnDependencyResolverTests
since I was not sure where to place it. If this is incorrect, place a comment and I'll move it 😄.