Add documentation to new .NET Standard projects #4001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkyeHoefling
suggested changes
Aug 20, 2020
There was a problem hiding this comment.
Overall this looks great! I think it will be very useful to have a clear direction on what the new Abstractions project is for and how types will be migrated over.
I do think there are some small changes that need to be made to make sure there are no confusions
Co-authored-by: Andrew Hoefling <[email protected]>
SkyeHoefling
approved these changes
Aug 20, 2020
david-poindexter
approved these changes
Aug 25, 2020
donker
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ahoefling and I were discussing the goals and guidelines for the DotNetNuke.Abstractions project, so I wrote up some guidelines, hoping that we could discuss and then document the plans for this project, and how it fits into the overall approach and direction of the DNN Platform.