Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize on CR/LF line endings #3998

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Standardize on CR/LF line endings #3998

merged 1 commit into from
Aug 20, 2020

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Aug 19, 2020

Closes #3995

@bdukes bdukes added this to the 9.7.1 milestone Aug 19, 2020
@SkyeHoefling
Copy link
Contributor

This also closes #3997

SkyeHoefling
SkyeHoefling approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@SkyeHoefling SkyeHoefling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just double checked the editorconfig docs and is the correct statement to add. Remember editorconfig won't automatically apply to all files at once. It will just overwrite the IDE settings, so as we submit PRs the line endings will update

@mitchelsellers mitchelsellers merged commit 61cd75c into dnnsoftware:develop Aug 20, 2020
@bdukes bdukes deleted the end_of_line branch August 20, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donker donker donker approved these changes

@mitchelsellers mitchelsellers mitchelsellers approved these changes

@SkyeHoefling SkyeHoefling SkyeHoefling approved these changes

Assignees
No one assigned
Labels
Type: Maintenance
Projects
None yet
Milestone
9.7.1
Development

Successfully merging this pull request may close these issues.
4 participants
@bdukes @SkyeHoefling @donker @mitchelsellers