Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate TabInfo.TabPermissionsSpecified #3941

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Deprecate TabInfo.TabPermissionsSpecified #3941

merged 1 commit into from
Jul 28, 2020

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Jul 28, 2020

Fixes #3940

david-poindexter
david-poindexter approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bdukes

@david-poindexter david-poindexter added this to the 9.7.0 milestone Jul 28, 2020
valadas
valadas approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too, it is just not used, always false and misleading to developers.

@valadas valadas merged commit da19702 into dnnsoftware:develop Jul 28, 2020
@bdukes bdukes deleted the deprecate-tab-permissions-specified branch August 18, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-poindexter david-poindexter david-poindexter approved these changes

@valadas valadas valadas approved these changes

Assignees
No one assigned
Labels
Type: Maintenance
Projects
None yet
Milestone
9.7.0
Development

Successfully merging this pull request may close these issues.

TabInfo.TabPermissionsSpecified is useless
3 participants
@bdukes @david-poindexter @valadas