-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes stylecop warnings on FolderManager.cs #3909
Conversation
Co-authored-by: Brian Dukes <[email protected]>
Co-authored-by: Brian Dukes <[email protected]>
@bdukes I see multiple of your suggestions with the "commit suggestion" button greyed out, that means you did it? |
I haven't committed any of those changes, but maybe @mitchelsellers' commit included some of them. |
Co-authored-by: Brian Dukes <[email protected]>
Co-authored-by: Brian Dukes <[email protected]>
Co-authored-by: Brian Dukes <[email protected]>
Ok, so I accepted the other suggestions, we just have to decide on the cast or adding an overload... |
I just pushed a change to add overloads (and deprecate the old overloads). |
Awesome @bdukes Love it. |
@david-poindexter @mitchelsellers I fixed the stylcop issues on the FolderManager.cs class for fixing the search issues after with a cleaner PR that does not have huge changes.