Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs that are not Indexed shouldn't be in the SiteMap #3897

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Tabs that are not Indexed shouldn't be in the SiteMap #3897

merged 1 commit into from
Jul 7, 2020

Conversation

ajwaka
Copy link
Contributor

@ajwaka ajwaka commented Jul 6, 2020

Fixes #3896

Summary

Non-indexed tabs should not be included in the sitemap. This effectively tells the crawler two different statements.

The only change needed is to validate that the tab is supposed to be index prior to exporting it to the sitemap.

@dnfadmin
Copy link

dnfadmin commented Jul 6, 2020

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and is consistent with the documented "Feature" of this setting.

@bdukes bdukes added this to the 9.7.0 milestone Jul 6, 2020
@bdukes bdukes merged commit 08698c7 into dnnsoftware:develop Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non Indexed Tabs should not be in the SiteMap
4 participants