-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StyleCop fixes #3831
StyleCop fixes #3831
Conversation
😦 Looks like these auto-fixes aren't without their bugs… Ugh. |
I was able to find a way to automate applying most of the fixes. It's not 100%, and a few of the documentation fixes are weird (e.g. SA1642). I'm going to try another round of automatically applying fixes and pinpoint the ones that cause compile problems. |
Alright, build succeeded. 55,464 warnings instead of 194,461 warnings on the previous build. Also shaved 7 minutes off the build. I'm going to manually apply/fix some of the auto-fixes that caused build errors. Y'all can merge this now and I'll push those changes as a separate PR, or I can push to this PR if nothing's moved on it before I'm done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a "spot check", it looks fine to me and I resolved 2 small conflicts. Looks good to me
Hmm, we have a new error, not sure if caused by my fixing of conflicts, they where pretty basic to resolve... |
Thanks @valadas! I've just pushed a change which should fix it. One side moved the |
Also, with the SA1200 change, we're down to 36,883 warnings. |
Oh, sorry, my bad :) /azp run |
/azp run |
No pipelines are associated with this pull request. |
Cool, it builds :) Can we get a second approver @dnnsoftware/approvers |
Yessir |
Most of the auto-fixes