Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 09.06.02.config #3829

Merged
merged 4 commits into from
Jun 25, 2020
Merged

Create 09.06.02.config #3829

merged 4 commits into from
Jun 25, 2020

Conversation

Tychodewaard
Copy link
Contributor

Add webp support

Summary

Add webp support
Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Tychodewaard!

@bdukes bdukes added this to the 9.6.2 milestone Jun 9, 2020
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is nothing technically wrong here, just putting my "request changes" to make sure nobody merges this before we have decided if the next version is 9.6.2 or 9.7.0.
If 9.7.0 then we must not merge this until we get there. If we do decide we go with 9.6.2 then I think we could just rename the file and get this together with 9.6.2 as it is not any risk IMO

@bdukes
Copy link
Contributor

bdukes commented Jun 12, 2020

Yeah, if we're doing a 9.6.2 release, let's include this.

@valadas
Copy link
Contributor

valadas commented Jun 13, 2020

Ok, so let's decide on the next meeting and we can adjust the filename accordingly...

This not being a breaking change, we can make it happen in 9.6.2
@valadas valadas changed the title Create 09.07.00.config Create 09.06.02.config Jun 23, 2020
@valadas valadas self-assigned this Jun 23, 2020
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just taking a note here, I will test an upgrade and a clean install before merging this.

DNN Platform/Website/Install/Config/09.06.02.config Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants