Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure yarn runs when module is built #3726

Merged
merged 3 commits into from
May 4, 2020
Merged

Ensure yarn runs when module is built #3726

merged 3 commits into from
May 4, 2020

Conversation

donker
Copy link
Contributor

@donker donker commented May 4, 2020

Currently the react scripts are not built when running a build. This PR fixes that.

@donker donker added this to the 9.7.0 milestone May 4, 2020
@donker donker requested review from mtrutledge and valadas May 4, 2020 09:54
mitchelsellers
mitchelsellers approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a WIP merge to a feature branch approving and merging

@mitchelsellers mitchelsellers merged commit 386c8ac into dnnsoftware:feature/resource-manager May 4, 2020
@donker donker deleted the rmfix2 branch May 7, 2020 15:20
@valadas valadas modified the milestones: 9.7.0, 9.8.0 Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchelsellers mitchelsellers mitchelsellers approved these changes

@mtrutledge mtrutledge Awaiting requested review from mtrutledge

@valadas valadas Awaiting requested review from valadas

Assignees
No one assigned
Labels
Type: Bug Type: Build/Release
Projects
None yet
Milestone
9.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@donker @mitchelsellers @valadas