Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate out CI from local package build #3476

Merged
merged 4 commits into from
Jan 15, 2020
Merged

Separate out CI from local package build #3476

merged 4 commits into from
Jan 15, 2020

Conversation

donker
Copy link
Contributor

@donker donker commented Jan 13, 2020

This PR will make the default cake build avoid:

  1. Creating NuGet packages
  2. Tweak the checksum of default.aspx

The advantage is that this avoids unnecessary work and avoids potential mishaps for people building locally. You can still call the CI build using the target BuildAll.

@donker donker requested a review from valadas January 13, 2020 22:27
valadas
valadas approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Build/Cake/ci.cake Show resolved Hide resolved
@valadas valadas added this to the 9.5.0 milestone Jan 15, 2020
@valadas valadas merged commit 6a75408 into dnnsoftware:develop Jan 15, 2020
@donker donker deleted the cibuild branch January 15, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchelsellers mitchelsellers mitchelsellers approved these changes

@valadas valadas valadas approved these changes

Assignees
No one assigned
Labels
Effort: Low Priority: Medium Status: Closed Type: Build/Release
Projects
None yet
Milestone
9.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@donker @mitchelsellers @valadas