Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNN-29164 - Open page settings can't display data for correct page #3424

Merged

Conversation

berkarslan-xo
Copy link
Contributor

Fixes #1116

Summary
When the script got loaded the first time, a wrong page id was getting sent in the XHR request which caused this issue (there were multiple page requests being sent and the order of responses for that requests play an important role in this bug's intermittent occurrence).

Demo: https://drive.google.com/open?id=1RvwR04B8iPrDdqrMAInCK3N0kN1cWMe2

Note: This is the copy of the PR in dnnsoftware/Dnn.AdminExperience#1117

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants