Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Module Action Menu Move Dropdown CSS issues #5783

Closed
2 tasks done
Timo-Breumelhof opened this issue Aug 8, 2023 · 0 comments · Fixed by #5784
Closed
2 tasks done

[Bug]: Module Action Menu Move Dropdown CSS issues #5783

Timo-Breumelhof opened this issue Aug 8, 2023 · 0 comments · Fixed by #5784

Comments

@Timo-Breumelhof
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

I created a new Theme for DNNCommunity and the Module Action Menus all look fine, but the Move (last one).
It looks like this:

image

IMO this is due to the use of

box-sizing: border-box

In the theme and the items having a fixed height:

And thus they are not high enough when you use border-box.

Also this is the only Action Menu dropdown that has a font-family defined for some reason.

I first tested this:

div.actionMenu ul.dnn_mact > li.actionMenuMove > ul li {
    box-sizing: content-box;
    height: auto;
    font-family:inherit;
}

To see if removing the height works in an content-box situation.

And then:

div.actionMenu ul.dnn_mact > li.actionMenuMove > ul li {
    box-sizing: border-box;
    height: auto;
    font-family:inherit;
}

The result is the same, meaning that the height and font-family can be removed IMO

Steps to reproduce?

  1. Use a theme that centrally defines box-sizing: border-box
  2. Make sure it does not have an box-sizing: content-box; definition for the Medule action Menu
  3. See the padding issue in the Move Module dropdown

Current Behavior

image

Expected Behavior

image

Relevant log output

No response

Anything else?

No response

Affected Versions

9.12.0 (latest release)

What browsers are you seeing the problem on?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
Timo-Breumelhof added a commit to Timo-Breumelhof/Dnn.Platform that referenced this issue Aug 8, 2023
- Removed fixed height 
- Removed Font Family Arial
valadas added a commit that referenced this issue Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant