Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exported types #319

Merged
merged 2 commits into from
Dec 21, 2023
Merged

fix: exported types #319

merged 2 commits into from
Dec 21, 2023

Conversation

nikeee
Copy link
Contributor

@nikeee nikeee commented Dec 20, 2023

Doesn't migrate to ESM, but fixes the exported module types instead.

Resolves #284

@nikeee nikeee mentioned this pull request Dec 20, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (945034d) 100.00% compared to head (ae299c0) 100.00%.
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff            @@
##              next      #319   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           33        33           
=========================================
  Hits            33        33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@dnlup dnlup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nikeee this looks great

@dnlup dnlup merged commit 6daab84 into dnlup:next Dec 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to ESM
2 participants