Pass the PictureConfiguration to obtainKey #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way the ExactAssetPicture can use the DefaultAssetBundle derived from context through the LocalPictureConfiguration instead of always defaulting to the rootBundle. This is helpful for tests and for local widget context assets. All other provides just ignore the configuration. This analogous to the implementation of Image.asset in Flutter.
|
This should be ready to merge, the failure was the lint failure from the other PR. |
|
This is going to be released on v0.10.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way the ExactAssetPicture can use the DefaultAssetBundle derived
from context through the LocalPictureConfiguration instead of always defaulting
to the rootBundle. This is helpful for tests and for local widget
context assets. All other provides just ignore the configuration.
This analogous to the implementation of Image.asset in Flutter.
Fix #117