-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DrawerList): add overflowingTextOptions
for CSS hyphens
, overflow-wrap
, word-break
, overflow
#4480
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Thanks for checking this out! Thought it made sense for long words without spaces, as my use case needs, but seeing that it also breaks sentences that simply could span several lines makes me unsure 🤔 I like the idea of being able to send it as prop |
I can make a new optional property called something like Or maybe just |
I think this sounds like a good idea! Thank you! |
c1443d5
to
9e85134
Compare
hyphenation
property to support hyphens when text wraps across multiple lines
packages/dnb-design-system-portal/src/docs/uilib/components/fragments/drawer-list/Examples.tsx
Outdated
Show resolved
Hide resolved
hyphenation
property to support hyphens when text wraps across multiple lineshyphenation
prop supporting hyphens when text wraps across multiple lines
...ests__/__image_snapshots__/drawerlist-for-sbanken-have-to-match-the-disabled-option.snap.png
Outdated
Show resolved
Hide resolved
3b68b6e
to
c86ee8e
Compare
9a55c2b
to
d2a1a1b
Compare
d2a1a1b
to
d9560d3
Compare
hyphenation
prop supporting hyphens when text wraps across multiple lineshyphenation
supporting hyphens when text wraps across multiple lines
…ross multiple lines
d9560d3
to
8b3022f
Compare
hyphenation
supporting hyphens when text wraps across multiple lineshyphenation
supporting hyphens when item text wraps across multiple lines
hyphenation
supporting hyphens when item text wraps across multiple linesoverflowingTextOptions
for CSS hyphens, overflow-wrap, word-break, overflow
overflowingTextOptions
for CSS hyphens, overflow-wrap, word-break, overflowoverflowingTextOptions
for CSS hyphens
, overflow-wrap
, word-break
, overflow
In the latest commit, I've renamed from
FYI @tujoworker |
Initial feature request here: https://dnb-it.slack.com/archives/CMXABCHEY/p1737113652911309
Read more about css property
hyphens
here: https://developer.mozilla.org/en-US/docs/Web/CSS/hyphens