Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Field.Date): add built in error messaging for min and max dates (WIP) #4469

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

feat(Field.Date): add built in error messaging for min and max dates (WIP) #4469

wants to merge 24 commits into from
+678 −16

Conversation

joakbjerk
Copy link
Contributor

@joakbjerk joakbjerk commented Jan 16, 2025 •
edited
Loading

WIP

  • Make ´DatePickerInput´ work with both status props and internal min max date validation
  • Add range logic for useDateLimitValidationMessage hook
  • Find appropriate format for dates in error messaging
  • Add tests
  • Add example in docs
  • Move functionality Field.Date
  • Move docs over to Field.Date
  • Move tests over to Field.Date
  • fix type errors

@vercel Vercel
Copy link

vercel bot commented Jan 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 5:27pm

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jan 16, 2025 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@joakbjerk joakbjerk changed the title feat(DatePicker): add built in error messaging for min and max dates (WIP) feat(Field.Date): add built in error messaging for min and max dates (WIP) Jan 22, 2025
@joakbjerk joakbjerk force-pushed the feat/datepicker-min-max-date-error-message branch from fdecfdf to 7c09b9f Compare January 22, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joakbjerk