Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Upload): improve typing of id property #4403

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

langz
Copy link
Contributor

@langz langz commented Dec 13, 2024

No description provided.

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 1:06pm

@langz langz changed the title chore(Upload): improve typing of id property chore(Upload): improve typing of id property Dec 13, 2024
@langz langz force-pushed the chore/update-upload-id-type branch from a1059ea to dbc42d9 Compare December 13, 2024 12:04
Copy link

codesandbox-ci bot commented Dec 13, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I think we can used/import the this type SharedStateId for simplification. We do that other places too.

packages/dnb-eufemia/src/components/upload/types.ts Outdated Show resolved Hide resolved
@langz langz force-pushed the chore/update-upload-id-type branch from dbc42d9 to 0774f14 Compare December 13, 2024 12:47
@langz langz merged commit 1800282 into main Dec 13, 2024
5 of 9 checks passed
@langz langz deleted the chore/update-upload-id-type branch December 13, 2024 12:48
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.61.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants