Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Upload): improves readability in examples #4373

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

langz
Copy link
Contributor

@langz langz commented Dec 6, 2024

Better to duplicate, as it makes it easier to read the code examples.

Previously, one would read useMockFiles(setFiles, { errorMessage: 'This is no real file!' }) in the example code, but not be able to see what useMockFiles would do.

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2024 0:23am

Copy link

codesandbox-ci bot commented Dec 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean Code 🤩

@langz langz merged commit 3a6eb63 into main Dec 9, 2024
10 checks passed
@langz langz deleted the chore/improve-examples-upload branch December 9, 2024 09:03
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.60.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants