Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(portal): expand button no longer below scrollbar #4338

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

snorrekim
Copy link
Contributor

@snorrekim snorrekim commented Nov 25, 2024

  • Also fixed not scrolling to current page when opening menu on small screens

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 3:07pm

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@langz langz marked this pull request as ready for review November 25, 2024 15:37
@langz langz changed the title fix(portal): expand button no longer below scrollbar chore(portal): expand button no longer below scrollbar Nov 25, 2024
Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Wondering if we should move the badge as well:

Screenshot 2024-11-25 at 21 07 15

@snorrekim snorrekim merged commit 4a0fea1 into main Nov 27, 2024
11 checks passed
@snorrekim snorrekim deleted the feat/portal-expand-icon-scroll branch November 27, 2024 12:38
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.58.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants