Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Forms): add support for using a function references instead of a string based id #4331

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

tujoworker
Copy link
Member

This feature allows developers to use a function or a React Context as the reference instead of a string-based ID. This can be useful for ensuring a safe local scope, especially when multiple form handlers are present.

const myReference= () => null

const MyField = () => {
  const { data } = Form.useData(myReference)
  return data.foo
} 

render(
<>
  <Form.Handler id={myReference}>
    ...
  </Form.Handler>
  
  <MyField />
</>
)

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2024 11:09am

Copy link

codesandbox-ci bot commented Nov 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@langz
Copy link
Contributor

langz commented Nov 23, 2024

We could perhaps add the example from the pr description to somewhere in our docs, just to demo what's now possible 🙏

@tujoworker tujoworker force-pushed the feat/forms-handler-with-instance branch from afe1278 to 4922654 Compare November 23, 2024 10:29
@tujoworker tujoworker changed the title feat(Forms): add support for using a function reference instead of a string based id feat(Forms): add support for using a function references instead of a string based id Nov 23, 2024
@tujoworker tujoworker force-pushed the feat/forms-handler-with-instance branch 2 times, most recently from 000c836 to 3dcb733 Compare November 23, 2024 10:34
@tujoworker tujoworker force-pushed the feat/forms-handler-with-instance branch 2 times, most recently from 721f5b0 to 0d766e7 Compare November 23, 2024 10:55
@tujoworker
Copy link
Member Author

We could perhaps add the example from the pr description to somewhere in our docs, just to demo what's now possible 🙏

I have updated the Getting started docs about it: https://github.com/dnbexperience/eufemia/pull/4331/files#diff-684f9fff83faef515cc8ff2f630bce6096237323831336e5e853054312b9a2ff

@langz langz merged commit a6e3bc3 into main Nov 25, 2024
10 checks passed
@langz langz deleted the feat/forms-handler-with-instance branch November 25, 2024 07:28
tujoworker pushed a commit that referenced this pull request Nov 29, 2024
## [10.58.0](v10.57.1...v10.58.0) (2024-11-29)

### ✨ Features

* **Forms:** add `showConfirmDialog` to Iterate.RemoveButton ([#4330](#4330)) ([76bddf0](76bddf0))
* **Forms:** add `variant="filled"` and `toolbarVariant="custom"` to Iterate.EditContainer and Iterate.ViewContainer ([#4329](#4329)) ([b2b9eef](b2b9eef))
* **Forms:** add support for using a function references instead of a string based id ([#4331](#4331)) ([a6e3bc3](a6e3bc3))
* **Forms:** enhance typing and add docs on how to deal with TypeScript types ([#4343](#4343)) ([10b199b](10b199b))
* **Forms:** introduce `decoupleForm` prop to Form.Handler ([#4332](#4332)) ([0b02b6e](0b02b6e))

### 🐛 Bug Fixes

* **DatePicker:** make sure the picker and input only reacts to the props that have changed ([#4342](#4342)) ([4cd52a3](4cd52a3))
* **Forms.Card:** remove outline when variant="basic" on Section containers when used in Wizard ([#4336](#4336)) ([ebad212](ebad212))
* **forms:** add `sessionStorageId` support to Field.Upload with empty file list rendering ([#4339](#4339)) ([d02a0af](d02a0af))
* **NumberFormat:** improve regex for parsing phone numbers with country codes ([#4340](#4340)) ([96613ed](96613ed)), closes [#4337](#4337)
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 10.58.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants