Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds Indeterminate to list of base fields components #4300

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

langz
Copy link
Contributor

@langz langz commented Nov 19, 2024

No description provided.

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 8:02pm

Copy link

codesandbox-ci bot commented Nov 19, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@tujoworker
Copy link
Member

Indeterminate is very rarely used. So I don't like the idea that it is listed by default.
Option can never be used alone, so it is also not that important to have listed in "this" list.

@langz
Copy link
Contributor Author

langz commented Nov 20, 2024

Indeterminate is very rarely used. So I don't like the idea that it is listed by default. Option can never be used alone, so it is also not that important to have listed in "this" list.

Fine by me :)

Does it make sense that we also don't display it here and here?

If I would want to read the docs for the Indeterminate and Option fields, it's difficult to find.

@tujoworker
Copy link
Member

Yes, there we can/should list them.

@langz langz force-pushed the chore/display-all-base-fields-in-menu branch from ecc9c63 to ded0933 Compare November 20, 2024 19:54
@langz langz changed the title chore: adds all base fields to menu chore: adds Indeterminate to list of base fields components Nov 20, 2024
@langz
Copy link
Contributor Author

langz commented Nov 20, 2024

Yes, there we can/should list them.

Good, I've now set componentType: 'base-toggle' for Indeterminate, so that it's included in the list of base fields components(ListBaseFieldComponents).

@tujoworker

@langz langz merged commit a58c999 into main Nov 21, 2024
10 checks passed
@langz langz deleted the chore/display-all-base-fields-in-menu branch November 21, 2024 08:46
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.57.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants