Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Forms): add asyncFileHandler to Field.Upload to support async file handling during upload #4281

Merged

Conversation

whitneymarkov
Copy link
Contributor

Add support for asynchronously processing/handling files so a virus checker can be used with the Field.Upload component.

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 2:24pm

Copy link

codesandbox-ci bot commented Nov 14, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work so far. A test would be good to have. Can be the same case as the example.

@tujoworker tujoworker changed the title Add support for handling field async, demos, docs feat(Forms): add asyncFileHandler to Field.Upload to support async file handling during upload Nov 14, 2024
@langz langz marked this pull request as ready for review November 15, 2024 08:37
@langz langz merged commit 030a09c into dnbexperience:main Nov 17, 2024
4 checks passed
@langz
Copy link
Contributor

langz commented Nov 17, 2024

Very nice work so far. A test would be good to have. Can be the same case as the example.

I've opened a PR for adding tests here, #4286

langz added a commit that referenced this pull request Nov 17, 2024
tujoworker pushed a commit that referenced this pull request Nov 18, 2024
## [10.56.0](v10.55.1...v10.56.0) (2024-11-18)

### 🐛 Bug Fixes

* **DatePicker:** ensure that `endMonth` does not fallback to `startMonth` when `endMonth` prop is defined ([#4254](#4254)) ([5281257](5281257))
* **Forms:** render given elements to `warning` and `info` properties ([#4261](#4261)) ([d60de25](d60de25))

### ⚡ Refactoring

* **DatePicker:** convert properties to camel case and deprecate those with snake case ([#4273](#4273)) ([a69a8aa](a69a8aa))

### ✨ Features

* **Field.Date:** add DatePickerProps ([#4160](#4160)) ([6a3765b](6a3765b))
* **Forms:** add `asyncFileHandler` to Field.Upload to support async file handling during upload ([#4281](#4281)) ([030a09c](030a09c))
* **Forms:** add inline HelpButton to all Field.* components as default (with option to open in Dialog) ([#4282](#4282)) ([e869a60](e869a60))
* **Forms:** add support for multiple info, warning and error messages given by an array ([#4284](#4284)) ([78f2fe8](78f2fe8))
* **ListFormat:** adds spacing properties ([#4255](#4255)) ([c72d999](c72d999))
* **Paragraph:** handle nested paragraphs (to be `span`'s) ([#4251](#4251)) ([ca3bbde](ca3bbde))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.56.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants