Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Forms): Fix use of unpolyfilled structuredClone in useData hook #4108

Merged
merged 2 commits into from
Oct 11, 2024
Merged

fix(Forms): Fix use of unpolyfilled structuredClone in useData hook #4108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58f0c6c
chore: Disallow use of global structuredClone
Oct 10, 2024
11a2dff
fix(Forms): Use polyfilled structuredClone instead of global in useData
Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/dnb-eufemia/.eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,13 @@
}
]
}
],
"no-restricted-globals": [
"error",
{
"name": "structuredClone",
"message": "Import `structuredClone` from '@ungap/structured-clone' instead."
}
]
}
},
Expand Down
6 changes: 6 additions & 0 deletions packages/dnb-eufemia/src/extensions/forms/Form/data-context/useData.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ import DataContext, {
} from '../../DataContext/Context'
import { SharedAttachments } from '../../DataContext/Provider'

/**
* Deprecated, as it is supported by all major browsers and Node.js >=v18
* So its a question of time, when we will remove this polyfill
*/
import structuredClone from '@ungap/structured-clone'

type PathImpl<T, P extends string> = P extends `${infer Key}/${infer Rest}`
? Key extends keyof T
? Rest extends ''
Expand Down
Loading