Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Dropdown): align tertiary dropdown triangle icon with button #4023

Merged
merged 5 commits into from
Sep 30, 2024
Merged

fix(Dropdown): align tertiary dropdown triangle icon with button #4023

merged 5 commits into from
Sep 30, 2024

Conversation

joakbjerk
Copy link
Contributor

@joakbjerk joakbjerk commented Sep 27, 2024 •
edited
Loading

Proposal on how to solve the alignment issue

Before:
image-2024-09-26-10-09-57-403

After:
Screenshot 2024-09-30 at 12 32 34

Screenshot 2024-09-30 at 12 32 27

@vercel Vercel
Copy link

vercel bot commented Sep 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 11:21am

@joakbjerk joakbjerk changed the title fix(Dropdown): align tertiary icon with dropdown triangle fix(Dropdown): align tertiary icon with dropdown triangle (WIP) Sep 27, 2024
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Sep 27, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@joakbjerk joakbjerk changed the title fix(Dropdown): align tertiary icon with dropdown triangle (WIP) fix(Dropdown): align tertiary dropdown triangle icon with button (WIP) Sep 30, 2024
@joakbjerk joakbjerk changed the title fix(Dropdown): align tertiary dropdown triangle icon with button (WIP) fix(Dropdown): align tertiary dropdown triangle icon with button Sep 30, 2024
@joakbjerk joakbjerk marked this pull request as ready for review September 30, 2024 11:23
langz
langz approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
A shame that we can't access dropdown-padding-horizontal, is there some other way of making use of this variable? 🤔

@langz
Copy link
Contributor

langz commented Sep 30, 2024

Does it make sense to have a screenshot test for these scenarios, to see if the different variations of arrows align up correctly?

@joakbjerk
Copy link
Contributor Author

Does it make sense to have a screenshot test for these scenarios, to see if the different variations of arrows align up correctly?

Sounds like that could be handy 🤔

@joakbjerk
Copy link
Contributor Author

Looks good to me 👍 A shame that we can't access dropdown-padding-horizontal, is there some other way of making use of this variable? 🤔

The only way I can think of is making it global through :root but, then it would loose the dropdown scope

@langz langz merged commit 1527d70 into main Sep 30, 2024
10 checks passed
@langz langz deleted the fix/dropdown-tertiary-icon-position branch September 30, 2024 14:53
tujoworker pushed a commit that referenced this pull request Sep 30, 2024
@semantic-release-bot
chore(release): 10.51.1 [skip ci]
6b63a44 
## [10.51.1](v10.51.0...v10.51.1) (2024-09-30)

### 📝 Documentation

* **Icon:** removes string as a icon type ([#4034](#4034)) ([4c53199](4c53199))

### 🐛 Bug Fixes

* **Dropdown:** align tertiary dropdown triangle icon with button ([#4023](#4023)) ([1527d70](1527d70))
* **Form.UseData:** getValue returns any instead of unknown ([#4035](#4035)) ([8434de9](8434de9))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.51.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langz langz langz approved these changes

@tujoworker tujoworker Awaiting requested review from tujoworker

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joakbjerk @langz @tujoworker