release of v10.46 #3879
Merged
release of v10.46 #3879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems to me that the `Build portal` step is not slower by removing the cache. So we probably should do that so we avoid the CSS file import issues, like [here](https://github.com/dnbexperience/eufemia/actions/runs/10559105350/job/29249868805).
Now looking like this: <img width="693" alt="image" src="https://github.com/user-attachments/assets/fef62217-ad4d-4be0-9ac7-03920cebf93b"> --------- Co-authored-by: Tobias Høegh <[email protected]>
See the tests for more details about what we now allow. In short, its not possible to have the perfect validation. Here is an [article about the challenge](https://www.abstractapi.com/guides/email-validation/email-address-pattern-validation). The Regex gets way larger when we try to validate IPv4 and especially IPv6. But I think we don't need a perfect validation for these, as these are exceptions anyways.
Quick example: ```tsx Input: <Field.SelectCountry path="/myCountry" /> Output: <Value.SelectCountry path="/myCountry" /> ```
Co-authored-by: Tobias Høegh <[email protected]>
…ilterData` in onSubmit and onChange instead (#3873) The property `filterSubmitData` on the `Form.Handler` was a way to define a filter, so data returned in the `onSubmit` got filtered. But I think we rather should return the filter function and let devs do it right where it happens. We do that already in `useData` and in `getData` that way. And now we also return `filterData` in the `onChange` event. The motivation is to keep consistency and rather offer declarative ways of defining filters. --------- Co-authored-by: Anders <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Co-authored-by: Tobias Høegh <[email protected]>
tujoworker
approved these changes
Sep 2, 2024
…yNumber` (#3771) Motivation from https://dnb-it.slack.com/archives/CMXABCHEY/p1720521252444219 --------- Co-authored-by: Tobias Høegh <[email protected]>
…iding a non-existent locale (#3817) Fixes #3818 --------- Co-authored-by: Tobias Høegh <[email protected]>
|
🎉 This PR is included in version 10.46.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.