Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms): solve issue when schema is used in Wizard #3680

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

tujoworker
Copy link
Member

Cannot access 'errorMessagesRef' before initialization

> Cannot access 'errorMessagesRef' before initialization
@tujoworker tujoworker requested a review from langz June 7, 2024 08:44
Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 8:54am

Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@langz
Copy link
Contributor

langz commented Jun 7, 2024

I don't think this is necessary related to the actual changes in this PR.
But I did some quick testing of the Wizard, and I've experienced that when changing the step, only the content of the step is changed, and not the "header"/part where I clicked, it still says step 2 out of 2, and that step 2 is active, even though I pressed step 1.

Take a look:

Screen.Recording.2024-06-07.at.11.53.22.mov

Should I report this as a issue? 🤔

@tujoworker
Copy link
Member Author

Should I report this as a issue? 🤔

Yes, that wold be nice 👍

@tujoworker tujoworker merged commit 8699b0c into main Jun 7, 2024
14 checks passed
@tujoworker tujoworker deleted the fix/field-props-ref-error branch June 7, 2024 10:35
@langz
Copy link
Contributor

langz commented Jun 7, 2024

Should I report this as a issue? 🤔

Yes, that wold be nice 👍

Issue #3685 is now created ✅

tujoworker pushed a commit that referenced this pull request Jun 11, 2024
## [10.35.0](v10.34.1...v10.35.0) (2024-06-11)

### 📝 Documentation

* add link to Eufemia's GitHub repository in menu bar ([#3670](#3670)) ([cdecbb3](cdecbb3))
* fix heading levels ([#3660](#3660)) ([d0bb28d](d0bb28d))
* **Forms:** fix broken link to forms/Wizard/Container ([#3656](#3656)) ([53cb041](53cb041))
* **Forms:** reqruied -> required ([#3655](#3655)) ([be82a51](be82a51))
* remove demos ([#3668](#3668)) ([90638ce](90638ce))

### 🐛 Bug Fixes

* add support for ::selection color for Chromium based browsers ([#3689](#3689)) ([6e49a9b](6e49a9b))
* **forms:** add help button to Field.Option ([#3678](#3678)) ([9210281](9210281))
* **forms:** ensure help button is rendered only once in Toggle and Boolean fields ([#3675](#3675)) ([d9e9478](d9e9478))
* **forms:** solve issue when schema is used in Wizard ([#3680](#3680)) ([8699b0c](8699b0c))
* **TextCounter:** exceeded message when variant up ([#3688](#3688)) ([22f1507](22f1507))

### ✨ Features

* **assets:** add sbanken logo svgs ([#3674](#3674)) ([1d7bcc0](1d7bcc0))
* **filter:** add support to filter array data based on wildcard `*` ([#3679](#3679)) ([1d93ac4](1d93ac4))
* **forms:** add edit and view containers to `Form.Section` ([#3652](#3652)) ([51bf7a2](51bf7a2))
* **forms:** add help property to ArraySelection field ([#3694](#3694)) ([f6b1224](f6b1224))
* **HelpButton:** ensure larger bounding area when size is set to small ([#3677](#3677)) ([97ca056](97ca056))
* **Logo:** Refactor Logo to ts ([#3611](#3611)) ([b1ca771](b1ca771))
* **NumberFormat:** add monospace support ([#3669](#3669)) ([940ddb6](940ddb6))
* refactor internal translation logic to not mutate the root context ([#3691](#3691)) ([49b0b45](49b0b45))
* **Table:** added handle to collapse all accordion rows ([#3666](#3666)) ([c09a697](c09a697))
* **Translation:** add support for type-safe keys ([#3681](#3681)) ([437ba83](437ba83))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 10.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants