Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms): add align prop to Field.Composition #3622

Merged
merged 1 commit into from
May 29, 2024

Conversation

tujoworker
Copy link
Member

@tujoworker tujoworker commented May 29, 2024

Also, we move the logic to replace {itemNr} into FieldBlock and ValueBlock instead of having them in the hooks. This yields the same result as before, but with broader support, because now also labels set in Field.Composition or Value.Composition will get processed.

@tujoworker tujoworker requested a review from joakbjerk May 29, 2024 08:48
Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 9:43am

Copy link

codesandbox-ci bot commented May 29, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@tujoworker tujoworker merged commit b8cfcd4 into main May 29, 2024
10 checks passed
@tujoworker tujoworker deleted the fix/composition-alignment branch May 29, 2024 11:25
tujoworker pushed a commit that referenced this pull request Jun 3, 2024
## [10.34.0](v10.33.0...v10.34.0) (2024-06-03)

### 🐛 Bug Fixes

* **DrawerList:** prevent call attempt for word if not function ([#3613](#3613)) ([66e04ba](66e04ba))
* **forms:** add align prop to Field.Composition ([#3622](#3622)) ([b8cfcd4](b8cfcd4))
* **forms:** enhance handling of schema TypeScript support ([#3635](#3635)) ([8e09651](8e09651)), closes [#3621](#3621)
* **forms:** ensure Value.Number renders with 0 ([#3620](#3620)) ([9f4a4d3](9f4a4d3))
* **TableContainer:** take full width when inside `Card` ([#3630](#3630)) ([c4d5c14](c4d5c14))

### ✨ Features

* **Autocomplete:** preliminary sbanken colors ([#3604](#3604)) ([fe42538](fe42538))
* **Blocks:** add ChildrenWithAge block ([#3619](#3619)) ([118932c](118932c))
* **Card:** stretch content inside when `stack` is true ([#3633](#3633)) ([d9177e9](d9177e9))
* **Checkbox, Radio:** fix border width for Sbanken brand ([#3612](#3612)) ([624ecf2](624ecf2))
* **forms:** add `active` prop to Wizard.Step ([#3639](#3639)) ([2804041](2804041))
* **forms:** add `countPath` prop to Iterate.Array ([#3615](#3615)) ([dfe96f5](dfe96f5))
* **forms:** add `defaultValue` to all `Value.*` components ([#3627](#3627)) ([4fdc778](4fdc778))
* **forms:** add `defaultValue` to all fields ([#3616](#3616)) ([58d698a](58d698a)), closes [#3615](#3615)
* **forms:** add `trueText` and `falseText` to Value.Boolean ([#3624](#3624)) ([c9cae37](c9cae37))
* **forms:** add hr to Wizard.EditButton ([#3637](#3637)) ([2018d16](2018d16))
* **forms:** add minimum and maximum to Value.Number ([#3636](#3636)) ([bbe3b2b](bbe3b2b))
* **forms:** add startWith prop to Field.Number ([#3632](#3632)) ([b6d177a](b6d177a))
* **FormStatus, Section:** change sbanken info color to purple ([#3589](#3589)) ([5356eb8](5356eb8))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 10.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants