Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Docs): replace all instances of postal code with postcode to adhere to british spelling standards #3259

Merged
merged 2 commits into from
Jan 22, 2024
Merged

chore(Docs): replace all instances of postal code with postcode to adhere to british spelling standards #3259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
355b73c
replace all instances of postal code with postcode
joakbjerk Jan 22, 2024
2b85df4
merge error fix
joakbjerk Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...tem-portal/src/docs/uilib/extensions/forms/feature-fields/PostalCodeAndCity.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
title: 'PostalCodeAndCity'
description: '`Field.PostalCodeAndCity` is a wrapper component for input of two separate values with user experience tailored for postal code and city values.'
description: '`Field.PostalCodeAndCity` is a wrapper component for input of two separate values with user experience tailored for postcode and city values.'
showTabs: true
theme: 'sbanken'
tabs:
Expand Down
6 changes: 3 additions & 3 deletions ...ortal/src/docs/uilib/extensions/forms/feature-fields/PostalCodeAndCity/info.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ showTabs: true

## Description

`Field.PostalCodeAndCity` is a wrapper component for input of two separate [input of strings](/uilib/extensions/forms/base-fields/String) with user experience tailored for postal code and city values.
`Field.PostalCodeAndCity` is a wrapper component for input of two separate [input of strings](/uilib/extensions/forms/base-fields/String) with user experience tailored for postcode and city values.

These fields is meant for Norwegian postal codes and cities. The postal code input takes a 4-digit string as values, since its meant for norwegian postal codes. A norwegian postal code can have a leading zero, which is why the value is a string and not a number.
More info about postal codes can be found at [Posten](https://www.bring.no/tjenester/adressetjenester/postnummer).
These fields is meant for Norwegian postcodes and cities. The postcode input takes a 4-digit string as values, since its meant for norwegian postcodes. A norwegian postcode can have a leading zero, which is why the value is a string and not a number.
More info about postcodes can be found at [Posten](https://www.bring.no/tjenester/adressetjenester/postnummer).

```jsx
import { Field } from '@dnb/eufemia/extensions/forms'
Expand Down
14 changes: 7 additions & 7 deletions ...src/docs/uilib/extensions/forms/feature-fields/PostalCodeAndCity/properties.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ showTabs: true

## Properties

| Property | Type | Description |
| ---------------------------------------------------------------------------------- | -------- | ---------------------------------------------------------------------------------------------------------------------- |
| `help` | `object` | _(optional)_ Provide a help button. Object consisting of `title` and `content`. |
| `postalCode` | `object` | _(required)_ Properties for the [Field.String](/uilib/extensions/forms/base-fields/String/) component for postal code. |
| `city` | `object` | _(required)_ Properties for the [Field.String](/uilib/extensions/forms/base-fields/String/) component for city. |
| [Space](/uilib/layout/space/properties) | Various | _(optional)_ Spacing properties like `top` or `bottom` are supported. |
| [FieldBlockProps](/uilib/extensions/forms/create-component/FieldBlock/properties/) | Various | _(optional)_ `FieldBlockProps` properties. |
| Property | Type | Description |
| ---------------------------------------------------------------------------------- | -------- | ------------------------------------------------------------------------------------------------------------------- |
| `help` | `object` | _(optional)_ Provide a help button. Object consisting of `title` and `content`. |
| `postalCode` | `object` | _(required)_ Properties for the [Field.String](/uilib/extensions/forms/base-fields/String/) component for postcode. |
| `city` | `object` | _(required)_ Properties for the [Field.String](/uilib/extensions/forms/base-fields/String/) component for city. |
| [Space](/uilib/layout/space/properties) | Various | _(optional)_ Spacing properties like `top` or `bottom` are supported. |
| [FieldBlockProps](/uilib/extensions/forms/create-component/FieldBlock/properties/) | Various | _(optional)_ `FieldBlockProps` properties. |
4 changes: 2 additions & 2 deletions packages/dnb-eufemia/src/shared/locales/en-GB.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,8 @@ export default {
phoneNumberLabel: 'Mobile number',
phoneNumberErrorRequired: 'You must enter a valid number',
postalCodeLabel: 'Postalc.',
postalCodeErrorRequired: 'You must enter a postal code',
postalCodeErrorPattern: 'This is not a valid postal code',
postalCodeErrorRequired: 'You must enter a postcode',
postalCodeErrorPattern: 'This is not a valid postcode',
cityLabel: 'City',
cityErrorRequired: 'You must enter a city',
selectCountryLabel: 'Country',
Expand Down
Loading