Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds Card stories #2887

Merged
merged 6 commits into from
Nov 14, 2023
Merged

chore: adds Card stories #2887

merged 6 commits into from
Nov 14, 2023

Conversation

langz
Copy link
Contributor

@langz langz commented Nov 13, 2023

Adds card stories, using fields from forms extension.

THOUGHTS:
Seems like my stories is not working as expected as of right now, as I'm doing:

<Card stack> 
   <>
      ...component1
      ...component2
   </>
</Card>

And must rather do the following for it to work:

<Card stack> 
   ...component1
   ...component2
</Card>

Should/could the first example with React fragment(<></>) work?


Added one more commit where I duplicate it, instead of sharing it, to make it work/look as expected.

Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 6:15pm

@langz langz changed the title chore: adds Cards stories chore: adds Card stories Nov 13, 2023
Copy link

codesandbox-ci bot commented Nov 13, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 31f37ce:

Sandbox Source
eufemia-starter Configuration

@tujoworker
Copy link
Member

Since the point of the Card component and its possibilities is missing out when not delivering a stack of components, I suggest to get each component programmatically.

See latest commit. I used your first commit and did not compare it, just in case, you made a change to the list of components.

@langz
Copy link
Contributor Author

langz commented Nov 13, 2023

Since the point of the Card component and its possibilities is missing out when not delivering a stack of components, I suggest to get each component programmatically.

See latest commit. I used your first commit and did not compare it, just in case, you made a change to the list of components.

Thanks, looks good, I'm very happy with that suggestion 🙏

@tujoworker tujoworker merged commit d66b723 into main Nov 14, 2023
7 checks passed
@tujoworker tujoworker deleted the chore/adds-card-stories branch November 14, 2023 10:51
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants