feat: add "use client" to components that use client side only React APIs (support for RSC) #2874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tujoworker
force-pushed
the
feat/rsc-use-client
branch
from
392be21 to
2fd02fd
Compare
…APIs (support for RSC) We have received several request to add a ["use client"](https://react.dev/reference/react/use-client) directive on top of each React component file that uses client side only React APIs. The reason is because Next.js takes in use a beta version of React to make RSC work (which is not OK in my opinion – its a super aggressive move 😣). To make a first move on this, I think we should automate this. And one way to do so, is to use Babel.js – because we use it in our tool-chain. There is already a very well written and tested plugin, written by Kyle Tsang I suggest to try out. 👉 [babel-plugin-transform-next-use-client](https://github.com/kyletsang/babel-plugin-transform-next-use-client) This must be the first time we take in use a dependency with 0 GitHub stars. If it turns out to work as expected, we should all give it a start of course.
tujoworker
force-pushed
the
feat/rsc-use-client
branch
from
2fd02fd to
b49a404
Compare
langz
approved these changes
Nov 10, 2023
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b49a404:
|
tujoworker
pushed a commit
that referenced
this pull request
Nov 12, 2023
## [10.13.0](v10.12.0...v10.13.0) (2023-11-12) ### 🐛 Bug Fixes * **Autocomplete:** ensure correct value selection during data change ([#2863](#2863)) ([d229ec2](d229ec2)) * **Autocomplete:** ensure on_change is firered during dataset update ([266ab6a](266ab6a)) * **PhoneNumber:** ensure correct selection of value ([#2852](#2852)) ([a20a764](a20a764)) * remove nullish operator to support Storybook v6 ([#2873](#2873)) ([f0bab63](f0bab63)) * typescript react type resolution in monorepos ([#2866](#2866)) ([44f04f3](44f04f3)) ### ✨ Features * **Accordion:** change sbanken expand icon to chevron ([#2854](#2854)) ([a7cb8b9](a7cb8b9)) * add "use client" to components that use client side only React APIs (support for RSC) ([#2874](#2874)) ([a84e962](a84e962)) * **Button:** change sbanken primary button text color to white ([#2855](#2855)) ([1571138](1571138)) * **Typography:** change sbanken bold to medium ([#2808](#2808)) ([4b0f930](4b0f930)) ### 📝 Documentation * **About:** add Snorre/Henrik/Ynge as contributors ([#2885](#2885)) ([fff72da](fff72da)) * **Autocomplete:** adds default value to keep_value props ([#2867](#2867)) ([7cae1fd](7cae1fd)) * fix font docs ([#2849](#2849)) ([13beec9](13beec9)) * **Ingress:** adds Ingress to docs ([#2879](#2879)) ([f771f3d](f771f3d)) * **Lead:** adds Lead to docs ([#2877](#2877)) ([0c0da7f](0c0da7f))
|
🎉 This PR is included in version 10.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have received several request to add a "use client" directive on top of each React component file that uses client side only React APIs.
The reason is because Next.js takes in use a beta version of React to make RSC work (which is not OK in my opinion – its a super aggressive move 😣).
To make a first move on this from our side, I think we should automate this. And one way to do so, is to use Babel.js – because we use it in our tool-chain.
There is already a very well written and tested plugin, written by Kyle Tsang I suggest to try out.
👉 babel-plugin-transform-next-use-client
This must be the first time we take in use a dependency with 0 GitHub stars. If it turns out to work as expected, we should all give it a star of course!
Other notes: