Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Grid): move Grid from layout to components #2750

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Conversation

tujoworker
Copy link
Member

This PR is based on #2748

  • E.g. Layout.GridContainer => Grid.Container etc.
  • Use chore as it is already a part of the change-log.

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia 🛑 Canceled (Inspect) Oct 13, 2023 7:35am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 12, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2fa4f58:

Sandbox Source
eufemia-starter Configuration

Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I found two more references to Layout.Grid.Item in:

  • packages/dnb-design-system-portal/src/docs/uilib/components/grid/item.mdx
  • packages/dnb-design-system-portal/src/docs/uilib/components/grid/item/info.mdx

Added comments for these two:

- E.g. `Layout.GridContainer` => `Grid.Container` etc.
- Use `chore` as it is already a part of the change-log.
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 10.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants