feat(Blockquote): fix sbanken styling, added small screen version #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8dbc475:
|
|
I made some changes to the dnb icon colors, the old solution seemed like a hack, and there was unused code in the css with what seemed like the correct colors. |
joakbjerk
approved these changes
Sep 12, 2023
tujoworker
pushed a commit
that referenced
this pull request
Sep 13, 2023
## [10.9.0](v10.8.0...v10.9.0) (2023-09-13) ### 📝 Documentation * **Dialog:** Dialog.Actions to Dialog.Action ([#2621](#2621)) ([9292305](9292305)) * **Forms:** restructure docs ([#2615](#2615)) ([ee24eba](ee24eba)) * **Modal:** updates components that inherits ModalPropTypes as camel case ([#2618](#2618)) ([beacaba](beacaba)) * **PaymentCard:** removes unused maker docs ([#2619](#2619)) ([dfeb6d5](dfeb6d5)) * **v10:** changes to PaymentCard's height & width ([#2643](#2643)) ([6985287](6985287)) ### ✨ Features * **Blockquote:** fix sbanken styling, added small screen version ([#2639](#2639)) ([d63d30d](d63d30d)) * **Forms:** add `Form.Handler` component ([#2644](#2644)) ([82873c7](82873c7)) * **Forms:** add Iterate.Array feature and merge useField and useValue to one hook useDataValue ([#2635](#2635)) ([b056994](b056994)) * **Forms:** merge FieldGroup into FieldBlock ([#2645](#2645)) ([56a1867](56a1867)) * **Heading:** remove font ligatures for sbanken headings ([#2614](#2614)) ([06c126f](06c126f)) * **PaymentCard:** updates height and weight to reflect Figma sketches ([#2617](#2617)) ([418fd2e](418fd2e)) * **ProgressIndicator:** Sbanken styling ([#2631](#2631)) ([03de0e3](03de0e3)) * **Skeleton:** Sbanken styling ([#2622](#2622)) ([fbc0083](fbc0083)) * **Tooltip:** Sbanken styling ([#2640](#2640)) ([f358b0a](f358b0a)), closes [#2622](#2622) [#2631](#2631) ### 🐛 Bug Fixes * **Dialog:** select whole input on focus given by focusSelector ([#2655](#2655)) ([a04f99a](a04f99a)), closes [#2652](#2652) * **Forms:** add polyfill for structuredClone ([#2636](#2636)) ([f00da48](f00da48)) * **Forms:** focus InputMasked when clicking label ([#2632](#2632)) ([3233326](3233326)) * **Forms:** remove FirstName, LastName and InfoCardSection ([#2627](#2627)) ([a2106cc](a2106cc)) * **MaskedInput:** make cleanedValue contain leading zeroes ([#2610](#2610)) ([86ad122](86ad122)) * **ProgressIndicator:** ensure correct positioning inside its boundary ([#2623](#2623)) ([0592961](0592961)) * **Section:** omit usage of nullish operator (??) to still support Storybook v4 ([#2646](#2646)) ([9a2e52f](9a2e52f)) * **useMedia:** ensure this hook works in StrictMode ([#2630](#2630)) ([74ebed9](74ebed9))
|
🎉 This PR is included in version 10.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Dnb changes
Updated background color for icons, the old solution looked like a hack, and there was unused code with proper colors.