feat(Dialog): sbanken theme #2626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1320267:
|
snorrekim
force-pushed
the
feat/dialog-sbanken
branch
from
0f0f050 to
1d414ae
Compare
tujoworker
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
I wonder if we should rebase this branch/PR as the color of this indicator should have Sbanken color now.
There was a problem hiding this comment.
I'll make sure to rebase before I merge
snorrekim
force-pushed
the
feat/dialog-sbanken
branch
from
1d414ae to
1320267
Compare
tujoworker
pushed a commit
that referenced
this pull request
Oct 19, 2023
## [10.10.0](v10.9.0...v10.10.0) (2023-10-19) ### 📝 Documentation * add info about how to find out what Eufemia version is used ([#2722](#2722)) ([0740b4c](0740b4c)) * **ArraySelection:** removes redundant/circular link ([94ca03a](94ca03a)) * **ArraySelection:** removes redundant/circular link ([#2735](#2735)) ([800589f](800589f)) * formats value prop as code ([#2692](#2692)) ([7c3b81e](7c3b81e)) * **Intro:** add breadcrumb for mitigate lack of orientation ([#2709](#2709)) ([69c3f16](69c3f16)) * **Layout:** fix import of ux-layout-spacing.png ([53db314](53db314)) * **Layout:** fix import of ux-layout-spacing.png ([#2733](#2733)) ([60067b7](60067b7)) * **Layout:** move layout (spacing and media query) docs to layout component docs ([#2724](#2724)) ([3f1f809](3f1f809)) * **Pagination:** Updated links to GitHub examples ([#2732](#2732)) ([3ced434](3ced434)) * **PaymentCard:** adds docs for formatCardNumber function ([c271cb6](c271cb6)) * **PaymentCard:** adds docs for formatCardNumber function ([#2702](#2702)) ([976c19f](976c19f)) * **PhoneNumber:** updates Component-specific props docs ([0265689](0265689)) * **PhoneNumber:** updates Component-specific props docs ([#2688](#2688)) ([751c5b2](751c5b2)) * **Portal:** add View Transition ([#2675](#2675)) ([4636276](4636276)) * **Portal:** fix anchor hash highlighting ([#2705](#2705)) ([9c6299e](9c6299e)) * update docs about `gatsby-plugin-eufemia-theme-handler` ([#2740](#2740)) ([61074a7](61074a7)) ### ✨ Features * **Anchor:** add correct icon padding + embed target blank icon for Sbanken compatibility ([#2770](#2770)) ([24cb49d](24cb49d)) * **Anchor:** fix no-style and no-hover ([#2739](#2739)) ([3965e3c](3965e3c)) * **Anchor:** hide anchor protocol icon ([#2749](#2749)) ([7472265](7472265)) * **Card:** add new Card component (beta) ([#2744](#2744)) ([cf0d5b6](cf0d5b6)) * deprecate FormRow and FormSet in favor of Flex layout and Forms Extension ([#2753](#2753)) ([6e392f9](6e392f9)) * **Dialog:** sbanken theme ([#2626](#2626)) ([f1781c1](f1781c1)) * **Dropdown:** add support for numeric values by using selectedKey or object based data entries ([#2666](#2666)) ([06281e4](06281e4)) * **Dropdown:** provide React refs support with the innerRef and buttonRef props ([#2665](#2665)) ([1d8d206](1d8d206)) * **fieldset:** add SASS mix-in `fieldsetReset` ([#2759](#2759)) ([c16be9b](c16be9b)) * **Flex:** add new Flex layout component ([#2748](#2748)) ([def1ad1](def1ad1)) * **Form.Handler:** call reset on form submit ([#2765](#2765)) ([4356b0f](4356b0f)) * **FormLabel and FieldBlock:** add heading typography size prop ([#2758](#2758)) ([3916fc2](3916fc2)) * **Forms:** add innerRef to Field.String for React.ref support ([#2679](#2679)) ([930b89d](930b89d)) * **Forms:** alignSelf on Flex components ([#2662](#2662)) ([0c46e36](0c46e36)) * **Forms:** enable tree-shaking compatibility ([#2713](#2713)) ([711bde7](711bde7)) * **forms:** Session storage on Provider and add defaultData prop ([62413f0](62413f0)) * **Layout:** add css Grid component ([#2731](#2731)) ([25ffbf8](25ffbf8)) * **Layout:** release Layout component ([#2628](#2628)) ([47f0018](47f0018)) * **Slider:** Sbanken styling ([#2716](#2716)) ([b8751bd](b8751bd)) * **Tabs:** Sbanken styling ([#2682](#2682)) ([68da886](68da886)), closes [#2640](#2640) [#2631](#2631) [#2622](#2622) * **Theme:** generate all properties in javascript file ([#2658](#2658)) ([6c70c63](6c70c63)) * **Theming:** refactor the internal structure + align DNB Eiendom theme and Anchor styles ([#2653](#2653)) ([c46caed](c46caed)) * **Upload:** Sbanken styling ([#2693](#2693)) ([992e10c](992e10c)) * **useMedia:** add new props: queries and breakpoints ([#2661](#2661)) ([a59633f](a59633f)) ### 🐛 Bug Fixes * **Anchor:** add --anchor-background-gutter ([#2721](#2721)) ([48a6084](48a6084)) * **Autocomplete:** fix rehydration disturbance ([#2761](#2761)) ([9ac6a4d](9ac6a4d)) * **Breadcrumb:** allow Button props on Breadcrumb.Item ([#2676](#2676)) ([ed95f6b](ed95f6b)) * **Breadcrumb:** avoid React warning about duplication of key ([#2687](#2687)) ([1e7d100](1e7d100)) * **DrawerList:** ensure links do wrap to new line ([#2700](#2700)) ([c994df4](c994df4)), closes [#2698](#2698) * **FieldBlock:** automate label in label detection ([#2668](#2668)) ([5902824](5902824)) * **Forms:** ensure error shows correct border and text colors ([#2717](#2717)) ([f1bc34d](f1bc34d)) * **forms:** Handle error display when no focus and blur events is called ([#2737](#2737)) ([63f6e87](63f6e87)) * **forms:** Phone number merged with country code, bugfixes ([#2755](#2755)) ([5e13b6c](5e13b6c)) * **Forms:** precede children over title in Selection ([#2664](#2664)) ([52e8d49](52e8d49)) * **GlobalStatus:** error state not applied on prop change ([#2768](#2768)) ([8864c4c](8864c4c)) * **Lead:** can now accept className prop without losing styling ([#2741](#2741)) ([3d68caa](3d68caa)) * **PaymentCard:** correctly export type for getCardData function ([cfaacdb](cfaacdb)) * **PaymentCard:** correctly export type for getCardData function ([#2704](#2704)) ([288de11](288de11)) * **PaymentCard:** removes excess space when formatting card number ([f079fa6](f079fa6)) * **PaymentCard:** removes excess space when formatting card number ([#2703](#2703)) ([4e35d27](4e35d27)) * **Slider:** allow negative values ([#2697](#2697)) ([380bb51](380bb51)) * **Slider:** make key navigation work when swapping position ([#2729](#2729)) ([b19a41e](b19a41e)) * **StepIndicator:** react on changes to `is_current` data property ([#2757](#2757)) ([b3a1a0f](b3a1a0f))
|
🎉 This PR is included in version 10.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sbanken theming of dialog
Discussion
Undefined cssVariables
How do we define cssVariables theme variables when there is no default value (because the value is theme specific)?
In this PR there are several variables in the common css that have no value, but as we can see, it drastically simplifies the theming files.
"Protected" cssVariables
In dnb-icon I've "protected" the default value whilst still making it available for customisation, again this leaves an undefined cssVariable
--icon-border-positioning--defaultthat can be used to override the variable.This was a way to protect it from failing if the variable is set to something that does not exist. But the Icon code does not need it itself. Should components make such allowances for others to use, or should they be more self contained?