feat: add support for React v18 #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4da783f:
|
langz
force-pushed
the
chore/react-18
branch
3 times, most recently
from
50a9536 to
6841952
Compare
langz
commented
Jun 16, 2023
langz
commented
Jun 19, 2023
packages/dnb-eufemia/src/components/input-masked/__tests__/InputMasked.test.tsx
Outdated
Show resolved
Hide resolved
langz
commented
Jun 19, 2023
packages/dnb-eufemia/src/components/input-masked/__tests__/InputMasked.test.tsx
Outdated
Show resolved
Hide resolved
langz
commented
Jun 19, 2023
packages/dnb-eufemia/src/components/pagination/__tests__/Pagination.test.tsx
Show resolved
Hide resolved
tujoworker
force-pushed
the
chore/react-18
branch
3 times, most recently
from
74c896e to
8285e8b
Compare
tujoworker
force-pushed
the
chore/react-18
branch
from
8285e8b to
9934f9d
Compare
tujoworker
approved these changes
Jul 4, 2023
|
Great job everyone 👏👏👏 |
tujoworker
force-pushed
the
chore/react-18
branch
from
9934f9d to
bda90aa
Compare
tujoworker
force-pushed
the
chore/react-18
branch
from
bda90aa to
4da783f
Compare
tujoworker
pushed a commit
that referenced
this pull request
Jul 6, 2023
## [10.4.0](v10.3.0...v10.4.0) (2023-07-06) ### 🐛 Bug Fixes * fix various types in tests and examples to prepare for React v18 ([#2507](#2507)) ([06c3202](06c3202)) ### ✨ Features * add support for React v18 ([#2481](#2481)) ([31a2d2b](31a2d2b)), closes [/github.com//pull/2481#issuecomment-1601630753](https://github.com/dnbexperience//github.com/dnbexperience/eufemia/pull/2481/issues/issuecomment-1601630753) [/github.com//pull/2481#issuecomment-1601606984](https://github.com/dnbexperience//github.com/dnbexperience/eufemia/pull/2481/issues/issuecomment-1601606984) [/github.com/dnbexperience/eufemia/blob/1e8021ccea7b03f9a60c78cc6760388ac36b55b1/packages/dnb-eufemia/src/components/tooltip/TooltipPortal.tsx#L8](https://github.com/dnbexperience//github.com/dnbexperience/eufemia/blob/1e8021ccea7b03f9a60c78cc6760388ac36b55b1/packages/dnb-eufemia/src/components/tooltip/TooltipPortal.tsx/issues/L8) [#2511](#2511) * **Avatar:** sbanken styling ([#2510](#2510)) ([389ccc0](389ccc0)) * **Button:** sbanken tertiary icon button hover and focus ([#2512](#2512)) ([23b3935](23b3935)) * **ScrollView:** add sbanken styling to scrollbar ([#2514](#2514)) ([5d2011e](5d2011e)) * **Table:** Sbanken styling ([#2513](#2513)) ([bd0ae68](bd0ae68)) * **Tooltip:** remove group property to add React v18 compatibility ([#2511](#2511)) ([4e882eb](4e882eb))
|
🎉 This PR is included in version 10.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks left:
React v18in our code, it exists a few comments about what to do when we get v18, and do what's needed.react-dom/client- @tujoworker 👀 feat(Tooltip): remove group property to add React v18 compatibility #2511