Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(Button): remove tertiary button padding sbanken #2422

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

snorrekim
Copy link
Contributor

Summary

Removed tertiary button padding because the intended use is often in line with text above or below the button. This will bring it in line with DNB tertiary button.

@vercel
Copy link

vercel bot commented Jun 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview Jun 2, 2023 1:08pm

@snorrekim
Copy link
Contributor Author

A note, one of the screenshot tests was behaving weirdly because of the order the tests were run in (so i fixed it). If we are testing both parent and child component, then we need to test the parent component before the child, because the tests changes the css.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 2, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c21ab93:

Sandbox Source
eufemia-starter Configuration

Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks you for the work 🎉

@snorrekim snorrekim requested a review from tujoworker June 2, 2023 13:21
@snorrekim snorrekim merged commit cc9a18b into main Jun 2, 2023
@snorrekim snorrekim deleted the style/button-tertiary-padding-sbanken branch June 2, 2023 13:23
tujoworker pushed a commit that referenced this pull request Jun 16, 2023
## [10.1.0](v10.0.0...v10.1.0) (2023-06-16)

### 💈 Style Changes

* **Button:** remove tertiary button padding sbanken ([#2422](#2422)) ([cc9a18b](cc9a18b))

### ✨ Features

* added icons accounting, candle_stick, fortune_ball and scan ([#2424](#2424)) ([47ef4b0](47ef4b0))
* **Portal:** copy color values to the clipboard ([#2427](#2427)) ([c570e51](c570e51))
* **Portal:** copy icon name to clipboard ([3c1944c](3c1944c))

### 📝 Documentation

* **v10:** improves docs of Modal migration ([#2446](#2446)) ([d78d940](d78d940))

### 🐛 Bug Fixes

* **Autocomplete:** fix stretched form status when using suffix ([#2455](#2455)) ([5518728](5518728))
* **Icons:** fix broken Android icons ([#2391](#2391)) ([ea12f23](ea12f23))
* **Icons:** remove left-over icon types (TypeScript) ([#2476](#2476)) ([80d3dac](80d3dac))
* include themed style in `ui-theme-tags` CSS package ([#2383](#2383)) ([d24c10d](d24c10d))
* **InputMasked:** make `inner_ref` work when provided as a function ([#2461](#2461)) ([5f59c50](5f59c50))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants